content/browser/compositor/surface_display_output_surface.h - Issue 553213003: Avoid destroying surface before the parent surface stops referencing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/surface_display_output_surface.h

Issue 553213003: Avoid destroying surface before the parent surface stops referencing it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/image_transport_factory.h ('k') | content/browser/compositor/surface_display_output_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/surface_display_output_surface.h

diff --git a/content/browser/compositor/surface_display_output_surface.h b/content/browser/compositor/surface_display_output_surface.h

index 3549ad25f9e40114acb1da37541483ea7ddab6b9..ac1a3e2112d209156b0946b1414ddabac6840bd9 100644

--- a/content/browser/compositor/surface_display_output_surface.h

+++ b/content/browser/compositor/surface_display_output_surface.h

@@ -27,7 +27,7 @@ class SurfaceDisplayOutputSurface : public cc::OutputSurface,

// The underlying cc::Display and cc::SurfaceManager must outlive this class.

SurfaceDisplayOutputSurface(

cc::SurfaceManager* surface_manager,

- uint32_t surface_id_namespace,

+ cc::SurfaceIdAllocator* allocator,

const scoped_refptr<cc::ContextProvider>& context_provider);

virtual ~SurfaceDisplayOutputSurface();

@@ -54,7 +54,7 @@ class SurfaceDisplayOutputSurface : public cc::OutputSurface,

cc::SurfaceFactory factory_;

gfx::Size display_size_;

cc::SurfaceId surface_id_;

- cc::SurfaceIdAllocator allocator_;

+ cc::SurfaceIdAllocator* allocator_;

DISALLOW_COPY_AND_ASSIGN(SurfaceDisplayOutputSurface);

};