Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 553163004: [telemetry] Reland MSR power monitor. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Reland MSR power monitor. New! With: - Disable for platforms that report no data. - Extra logging to help diagnose why it's disabled. - Fixes asserts (assert _var is not None instead of just _var). BUG=336558 TEST=python tools/telemetry/run_tests msr R=tonyg Committed: https://crrev.com/05905bc9e13ee53917bf5edaa9741f48672180e7 Cr-Commit-Position: refs/heads/master@{#294084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -9 lines) Patch
A tools/telemetry/bin/win/winring0.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 chunk +193 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor_unittest.py View 2 chunks +8 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dtu
6 years, 3 months ago (2014-09-10 01:36:07 UTC) #1
tonyg
lgtm
6 years, 3 months ago (2014-09-10 01:45:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/553163004/1
6 years, 3 months ago (2014-09-10 02:00:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 288da7a974756befe59cbde8666cc4812ba51d94
6 years, 3 months ago (2014-09-10 03:06:03 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05905bc9e13ee53917bf5edaa9741f48672180e7
Cr-Commit-Position: refs/heads/master@{#294084}

Powered by Google App Engine
This is Rietveld 408576698