Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 553163002: [DirectWrite] Limit noSubpixelForSmallSizeFont to low-DPI (Closed)

Created:
6 years, 3 months ago by eae
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, Rik, danakj, dglazkov+blink, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DirectWrite] Limit noSubpixelForSmallSizeFont to low-DPI Limit the noSubpixelForSmallSizeFont functionality that disables subpixel text for older fonts at sizes below 16px to low-DPI devices. At or above a 150% DPI subpixel text is enabled for all fonts assuming anti-aliasing is enabled. As the font code isn't aware of the DPI or device pixel ratio it needs to be supplied by Chrome though WebFontRendering. Chrome side change is in https://codereview.chromium.org/561503002/ R=cpu@chromium.org, dglazkov@chromium.org BUG=405445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181688

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M Source/platform/fonts/FontCache.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 chunk +14 lines, -7 lines 0 comments Download
M Source/web/win/WebFontRendering.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/win/WebFontRendering.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
eae
6 years, 3 months ago (2014-09-09 20:41:59 UTC) #2
eae
Confirmed to be working for 100%, 150% and 200% DPI.
6 years, 3 months ago (2014-09-09 23:23:44 UTC) #5
dglazkov
lgtm.
6 years, 3 months ago (2014-09-09 23:34:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/553163002/40001
6 years, 3 months ago (2014-09-09 23:49:30 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 00:24:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as 181688

Powered by Google App Engine
This is Rietveld 408576698