Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 553153005: Move extensions APIPermissionSet tests to extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
tfarina, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extensions APIPermissionSet tests to extensions_unittests They don't need to run in Chrome's unit_tests suite. Moved a test for a one-off filesystem permission hack into Chrome's PermissionsTest because the filesystem API lives in src/chrome. BUG=397165 TEST=extensions_unittests Committed: https://crrev.com/fe42c5547a37c12914164588e56546767d9c6bfd Cr-Commit-Position: refs/heads/master@{#294064}

Patch Set 1 #

Patch Set 2 : (api-permissions) cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -66 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 1 chunk +32 lines, -0 lines 1 comment Download
M extensions/common/permissions/api_permission_set_unittest.cc View 13 chunks +40 lines, -65 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
James Cook
yoz, PTAL. tfarina, FYI https://codereview.chromium.org/553153005/diff/20001/chrome/common/extensions/permissions/permission_set_unittest.cc File chrome/common/extensions/permissions/permission_set_unittest.cc (right): https://codereview.chromium.org/553153005/diff/20001/chrome/common/extensions/permissions/permission_set_unittest.cc#newcode809 chrome/common/extensions/permissions/permission_set_unittest.cc:809: // The file system permissions ...
6 years, 3 months ago (2014-09-09 23:19:21 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-10 00:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/553153005/20001
6 years, 3 months ago (2014-09-10 00:14:38 UTC) #5
tfarina
lgtm (rubber-stamp)
6 years, 3 months ago (2014-09-10 00:19:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f93807c38430329083bee7c719040d4388408733
6 years, 3 months ago (2014-09-10 01:25:35 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe42c5547a37c12914164588e56546767d9c6bfd
Cr-Commit-Position: refs/heads/master@{#294064}

Powered by Google App Engine
This is Rietveld 408576698