Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 553153004: Chrome OS Touchpad Settings: Always update natural scrolling pref. (Closed)

Created:
6 years, 3 months ago by adlr
Modified:
6 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chrome OS Touchpad Settings: Always update natural scrolling pref. Natural (aka australian) scrolling occurs outside Chrome in the X11 touchpad driver. Chrome dictates via an inputcontrol script what the value (true/false) should be. The script notes (in the user's homedir) what the last set value is so that added devices get it applied. Unfortunately, what was happening was Chrome would update the pref before the user logged in, so the inputcontrol script couldn't make a note. Later, when a user was logged in and a new device was attached, the script wouldn't know if australian scrolling should be on or off. To fix, we always set australian scrolling whenever we consider sending touchpad value changes to the inputcontrol script. BUG=chromium:406480 TEST=Tested that when user logs in, chrome always sends the current value of natural scrolling to the inputcontrol script. Also tested that changing non-mouse/tp settings doesn't trigger calls to inputcontrol script. Committed: https://crrev.com/dc6bae3bdc5154b73600a1180c0a82859b271a3f Cr-Commit-Position: refs/heads/master@{#294058}

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chromeos/system/input_device_settings.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
adlr
6 years, 3 months ago (2014-09-09 22:34:22 UTC) #2
achuithb
Please add a comment explaining what's going on in here. Doesn't have to be as ...
6 years, 3 months ago (2014-09-09 22:57:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adlr@chromium.org/553153004/20001
6 years, 3 months ago (2014-09-09 23:25:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ea75a1672ab050d4d0ca32897ae8fb393e1bf4da
6 years, 3 months ago (2014-09-10 01:03:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:10 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc6bae3bdc5154b73600a1180c0a82859b271a3f
Cr-Commit-Position: refs/heads/master@{#294058}

Powered by Google App Engine
This is Rietveld 408576698