[Mac] Add text-editing accelerators to the User Manager.

chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/profiles/user_manager_mac.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_dialogs.h"
@@ skipping 37 matching lines @@
     : window_(window) {}
 
   // WebContentsDelegate implementation. Forwards all unhandled keyboard events
   // to the current window.
   virtual void HandleKeyboardEvent(
       content::WebContents* source,
       const content::NativeWebKeyboardEvent& event) OVERRIDE {
     if (![BrowserWindowUtils shouldHandleKeyboardEvent:event])
       return;
 
+    // -getCommandId returns -1 if the event isn't a chrome keyboard shortcut.
     int commandId = [BrowserWindowUtils getCommandId:event];
 
-    // Since the User Manager is a "top level" window, only handle close events.
-    if (commandId == IDC_CLOSE_WINDOW || commandId == IDC_EXIT) {
+    // From the chrome accelerators, only handle close window accelerators, and
+    // allow all other accelerators to be handled by the web contents.
+    if (commandId == -1 || commandId == IDC_CLOSE_WINDOW ||
+        commandId == IDC_EXIT) {
       // Not invoking +[BrowserWindowUtils handleKeyboardEvent here], since the
       // window in question is a ConstrainedWindowCustomWindow, not a
       // BrowserWindow.
       [window_ redispatchKeyEvent:event.os_event];

[groby-ooo-7-16, 2014/09/10 20:06:40]

Technically, valid commandIds should be handled via [[NSApp mainMenu]
performKeyEquivalent:event]

The difference is subtle - if you redispatch to |window_|, the event is first
offered to performKeyEquivalent on |window_|. If that can't handle the event,
it's handed off to [NSApp mainMenu].

That only matters if there's an extension command handler for the key event -
which means extension keypresses are still allowed through. I don't think you
want that.

I love key handling ;(

     }
   }
 
  private:
   ChromeEventProcessingWindow* window_;  // Used to redispatch key events.
 };
 
 // Window controller for the User Manager view.
 @interface UserManagerWindowController : NSWindowController <NSWindowDelegate> {
  @private
@@ skipping 130 matching lines @@
 void UserManagerMac::OnGuestProfileCreated(Profile* guest_profile,
                                            const std::string& url) {
   instance_ = new UserManagerMac(guest_profile);
   [instance_->window_controller_ showURL:GURL(url)];
 }
 
 void UserManagerMac::WindowWasClosed() {
   instance_ = NULL;
   delete this;
 }