DevTools: Do not switch to other profile when revealing a node

Source/devtools/front_end/profiler/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
+ * @implements {WebInspector.ProfileType.DataDisplayDelegate}
  * @extends {WebInspector.VBox}
  * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
  * @param {!WebInspector.HeapProfileHeader} profile
  */
 WebInspector.HeapSnapshotView = function(dataDisplayDelegate, profile)
 {
     WebInspector.VBox.call(this);
 
     this.element.classList.add("heap-snapshot-view");
 
     profile.profileType().addEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, this._onReceiveSnapshot, this);
     profile.profileType().addEventListener(WebInspector.ProfileType.Events.RemoveProfileHeader, this._onProfileHeaderRemoved, this);
 
     if (profile.profileType().id === WebInspector.TrackingHeapSnapshotProfileType.TypeId) {
         this._trackingOverviewGrid = new WebInspector.HeapTrackingOverviewGrid(profile);
         this._trackingOverviewGrid.addEventListener(WebInspector.HeapTrackingOverviewGrid.IdsRangeChanged, this._onIdsRangeChanged.bind(this));
     }
 
+    this._parentDataDisplayDelegate = dataDisplayDelegate;
+
     this._splitView = new WebInspector.SplitView(false, true, "heapSnapshotSplitViewState", 200, 200);
     this._splitView.show(this.element);
 
     this._containmentView = new WebInspector.VBox();
     this._containmentView.setMinimumSize(50, 25);
-    this._containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid(dataDisplayDelegate);
+    this._containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid(this);
     this._containmentDataGrid.show(this._containmentView.element);
     this._containmentDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     this._statisticsView = new WebInspector.HeapSnapshotStatisticsView();
 
     this._constructorsView = new WebInspector.VBox();
     this._constructorsView.setMinimumSize(50, 25);
 
-    this._constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid(dataDisplayDelegate);
+    this._constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid(this);
     this._constructorsDataGrid.show(this._constructorsView.element);
     this._constructorsDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     this._diffView = new WebInspector.VBox();
     this._diffView.setMinimumSize(50, 25);
 
-    this._diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid(dataDisplayDelegate);
+    this._diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid(this);
     this._diffDataGrid.show(this._diffView.element);
     this._diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     if (profile._hasAllocationStacks) {
         this._allocationView = new WebInspector.VBox();
         this._allocationView.setMinimumSize(50, 25);
-        this._allocationDataGrid = new WebInspector.AllocationDataGrid(profile.target() , dataDisplayDelegate);
+        this._allocationDataGrid = new WebInspector.AllocationDataGrid(profile.target() , this);
         this._allocationDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._onSelectAllocationNode, this);
         this._allocationDataGrid.show(this._allocationView.element);
 
         this._allocationStackView = new WebInspector.HeapAllocationStackView(profile.target());
         this._allocationStackView.setMinimumSize(50, 25);
 
         this._tabbedPane = new WebInspector.TabbedPane();
         this._tabbedPane.closeableTabs = false;
         this._tabbedPane.headerElement().classList.add("heap-object-details-header");
     }
@@ skipping 19 matching lines @@
         var retainingPathsTitle = retainingPathsTitleDiv.createChild("span");
         retainingPathsTitle.textContent = WebInspector.UIString("Retainers");
         this._retainmentView.element.appendChild(retainmentViewHeader);
 
         splitViewResizer = retainmentViewHeader;
         this._objectDetailsView = this._retainmentView;
     }
     this._splitView.hideDefaultResizer();
     this._splitView.installResizer(splitViewResizer);
 
-    this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid(dataDisplayDelegate);
+    this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid(this);
     this._retainmentDataGrid.show(this._retainmentView.element);
     this._retainmentDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._inspectedObjectChanged, this);
     this._retainmentDataGrid.reset();
 
     this._perspectives = [];
     this._perspectives.push(new WebInspector.HeapSnapshotView.SummaryPerspective());
     if (profile.profileType() !== WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType)
         this._perspectives.push(new WebInspector.HeapSnapshotView.ComparisonPerspective());
     this._perspectives.push(new WebInspector.HeapSnapshotView.ContainmentPerspective());
     if (this._allocationView)
@@ skipping 306 matching lines @@
     masterGrid: function(heapSnapshotView)
     {
         return null;
     },
 
    __proto__: WebInspector.HeapSnapshotView.Perspective.prototype
 }
 
 
 WebInspector.HeapSnapshotView.prototype = {
+    /**
+     * @override
+     * @param {?WebInspector.ProfileHeader} profile
+     * @return {?WebInspector.View}
+     */
+    showProfile: function(profile)
+    {
+        return this._parentDataDisplayDelegate.showProfile(profile);
+    },
+
+    /**
+     * @override
+     * @param {!HeapProfilerAgent.HeapSnapshotObjectId} snapshotObjectId
+     * @param {string} perspectiveName
+     */
+    showObject: function(snapshotObjectId, perspectiveName)
+    {
+        if (snapshotObjectId <= this._profile.maxJSObjectId)
+            this.highlightLiveObject(perspectiveName, snapshotObjectId);
+        else
+            this._parentDataDisplayDelegate.showObject(snapshotObjectId, perspectiveName);
+    },
+
     _refreshView: function()
     {
         this._profile.load(profileCallback.bind(this));
 
         /**
          * @param {!WebInspector.HeapSnapshotProxy} heapSnapshotProxy
          * @this {WebInspector.HeapSnapshotView}
          */
         function profileCallback(heapSnapshotProxy)
         {
             heapSnapshotProxy.getStatistics(this._gotStatistics.bind(this));
             var list = this._profiles();
             var profileIndex = list.indexOf(this._profile);
             this._baseSelect.setSelectedIndex(Math.max(0, profileIndex - 1));
             this._dataGrid.setDataSource(heapSnapshotProxy);
             if (this._trackingOverviewGrid)
                 this._trackingOverviewGrid._updateGrid();
         }
     },
 
     /**
      * @param {!WebInspector.HeapSnapshotCommon.Statistics} statistics
      */
-    _gotStatistics: function(statistics) {
+    _gotStatistics: function(statistics)
+    {
         this._statisticsView.setTotal(statistics.total);
         this._statisticsView.addRecord(statistics.code, WebInspector.UIString("Code"), "#f77");
         this._statisticsView.addRecord(statistics.strings, WebInspector.UIString("Strings"), "#5e5");
         this._statisticsView.addRecord(statistics.jsArrays, WebInspector.UIString("JS Arrays"), "#7af");
         this._statisticsView.addRecord(statistics.native, WebInspector.UIString("Typed Arrays"), "#fc5");
         this._statisticsView.addRecord(statistics.total, WebInspector.UIString("Total"));
     },
 
     _onIdsRangeChanged: function(event)
     {
@@ skipping 368 matching lines @@
     {
         this._changePerspective(event.target.selectedIndex);
         // FIXME: This is needed by CodeSchool extension.
         this._onSelectedViewChanged(event);
     },
 
     _onSelectedViewChanged: function(event)
     {
     },
 
+    /**
+     * @param {number} selectedIndex
+     */
     _changePerspective: function(selectedIndex)
     {
         if (selectedIndex === this._currentPerspectiveIndex)
             return;
 
         this._currentPerspectiveIndex = selectedIndex;
 
         this._currentPerspective.deactivate(this);
         var perspective = this._perspectives[selectedIndex];
         this._currentPerspective = perspective;
@@ skipping 11 matching lines @@
 
         // The current search needs to be performed again. First negate out previous match
         // count by calling the search finished callback with a negative number of matches.
         // Then perform the search again the with same query and callback.
         this._searchFinishedCallback(this, -this._searchResults.length);
         this.performSearch(this.currentQuery, this._searchFinishedCallback);
     },
 
     /**
      * @param {string} perspectiveName
-     * @param {number} snapshotObjectId
+     * @param {!HeapProfilerAgent.HeapSnapshotObjectId} snapshotObjectId
      */
     highlightLiveObject: function(perspectiveName, snapshotObjectId)
     {
         this._changePerspectiveAndWait(perspectiveName, didChangePerspective.bind(this));
 
         /**
          * @this {WebInspector.HeapSnapshotView}
          */
         function didChangePerspective()
         {
@@ skipping 1277 matching lines @@
             name.textContent = frame.functionName;
             if (frame.scriptId) {
                 var urlElement = this._linkifier.linkifyScriptLocation(this._target, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1);
                 frameDiv.appendChild(urlElement);
             }
         }
     },
 
     __proto__: WebInspector.View.prototype
 }