Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 553053002: Emit actions and states from test_installer.py when not in quiet mode. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)
Modified:
6 years, 3 months ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Emit actions and states from test_installer.py when not in quiet mode. BUG=402081 R=gab@chromium.org Committed: https://crrev.com/0c998d54116eaf9f5f56254f0b193f1fd2ba46f5 Cr-Commit-Position: refs/heads/master@{#293981}

Patch Set 1 #

Total comments: 2

Patch Set 2 : verbose by default, quiet on demand. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/test/mini_installer/test_installer.py View 1 6 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
grt (UTC plus 2)
6 years, 3 months ago (2014-09-09 15:47:56 UTC) #1
gab
lgtm w/ nit https://codereview.chromium.org/553053002/diff/1/chrome/test/mini_installer/test_installer.py File chrome/test/mini_installer/test_installer.py (right): https://codereview.chromium.org/553053002/diff/1/chrome/test/mini_installer/test_installer.py#newcode95 chrome/test/mini_installer/test_installer.py:95: sys.stderr.write('Finished action %s\n' % action) Shouldn't ...
6 years, 3 months ago (2014-09-09 15:50:10 UTC) #2
grt (UTC plus 2)
https://codereview.chromium.org/553053002/diff/1/chrome/test/mini_installer/test_installer.py File chrome/test/mini_installer/test_installer.py (right): https://codereview.chromium.org/553053002/diff/1/chrome/test/mini_installer/test_installer.py#newcode95 chrome/test/mini_installer/test_installer.py:95: sys.stderr.write('Finished action %s\n' % action) On 2014/09/09 15:50:10, gab ...
6 years, 3 months ago (2014-09-09 15:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/553053002/1
6 years, 3 months ago (2014-09-09 15:57:07 UTC) #5
grt (UTC plus 2)
After discussing with jam@, I've switched the script to be verbose by default. PTAL.
6 years, 3 months ago (2014-09-09 16:41:25 UTC) #7
gab
lgtm
6 years, 3 months ago (2014-09-09 18:09:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/553053002/20001
6 years, 3 months ago (2014-09-09 18:11:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 26752f656a2b4dbe7fdcd4c5dbc125fe4bd19565
6 years, 3 months ago (2014-09-09 19:08:59 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c998d54116eaf9f5f56254f0b193f1fd2ba46f5
Cr-Commit-Position: refs/heads/master@{#293981}

Powered by Google App Engine
This is Rietveld 408576698