Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 553033002: Add figcaption case at 'computeAccessibilityIsIgnored()' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 if (hasContentEditableAttributeSet()) 670 if (hasContentEditableAttributeSet())
671 return false; 671 return false;
672 672
673 // List items play an important role in defining the structure of lists. The y should not be ignored. 673 // List items play an important role in defining the structure of lists. The y should not be ignored.
674 if (roleValue() == ListItemRole) 674 if (roleValue() == ListItemRole)
675 return false; 675 return false;
676 676
677 if (roleValue() == DialogRole) 677 if (roleValue() == DialogRole)
678 return false; 678 return false;
679 679
680 if (roleValue() == FigcaptionRole)
681 return false;
682
680 if (roleValue() == FigureRole) 683 if (roleValue() == FigureRole)
681 return false; 684 return false;
682 685
683 // if this element has aria attributes on it, it should not be ignored. 686 // if this element has aria attributes on it, it should not be ignored.
684 if (supportsARIAAttributes()) 687 if (supportsARIAAttributes())
685 return false; 688 return false;
686 689
687 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 690 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
688 // information on them. If we don't ignore them, they may emit signals expec ted to come from 691 // information on them. If we don't ignore them, they may emit signals expec ted to come from
689 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 692 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
(...skipping 1649 matching lines...) Expand 10 before | Expand all | Expand 10 after
2339 if (label && label->renderer()) { 2342 if (label && label->renderer()) {
2340 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2343 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2341 result.unite(labelRect); 2344 result.unite(labelRect);
2342 } 2345 }
2343 } 2346 }
2344 2347
2345 return result; 2348 return result;
2346 } 2349 }
2347 2350
2348 } // namespace blink 2351 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698