Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 55303006: Make sure the non browser/non app widget is fully visible when created on ash (Closed)

Created:
7 years, 1 month ago by oshima
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, ben+views_chromium.org, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Make sure the non browser/no app widget is fully visible when created on ash added minimum_visibility flag to WindowState to guarantee that the part of widget is always visible. BUG=308606 TEST=open TaskManager on 2nd display, close it, disconnect display, then open task manager again. minimum visibility is covered by test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232400

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -5 lines) Patch
M ash/shell/toplevel_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/toplevel_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 2 chunks +51 lines, -0 lines 0 comments Download
M ash/wm/window_state.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M ash/wm/window_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/widget_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
oshima
7 years, 1 month ago (2013-10-31 22:58:36 UTC) #1
sky
LGTM https://codereview.chromium.org/55303006/diff/30001/ash/wm/window_state.h File ash/wm/window_state.h (right): https://codereview.chromium.org/55303006/diff/30001/ash/wm/window_state.h#newcode151 ash/wm/window_state.h:151: // If the minimum visibilty is true, ash ...
7 years, 1 month ago (2013-10-31 23:27:44 UTC) #2
oshima
https://codereview.chromium.org/55303006/diff/30001/ash/wm/window_state.h File ash/wm/window_state.h (right): https://codereview.chromium.org/55303006/diff/30001/ash/wm/window_state.h#newcode151 ash/wm/window_state.h:151: // If the minimum visibilty is true, ash will ...
7 years, 1 month ago (2013-11-01 00:19:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/55303006/90001
7 years, 1 month ago (2013-11-01 00:38:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217134
7 years, 1 month ago (2013-11-01 04:26:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/55303006/90001
7 years, 1 month ago (2013-11-01 05:27:48 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 15:23:15 UTC) #7
Message was sent while issue was closed.
Change committed as 232400

Powered by Google App Engine
This is Rietveld 408576698