Fixing drag and drop visibility issues of tabs on a visiting desktop

chrome/browser/ui/ash/multi_user_window_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/multi_user_window_manager.h"
 
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "ash/ash_switches.h"
 #include "ash/session_state_delegate.h"
@@ skipping 150 matching lines @@
 void MultiUserWindowManager::SetWindowOwner(aura::Window* window,
                                             const std::string& user_id) {
   // Make sure the window is valid and there was no owner yet.
   DCHECK(window);
   DCHECK(!user_id.empty());
   if (GetWindowOwner(window) == user_id)
     return;
   DCHECK(GetWindowOwner(window).empty());
   window_to_entry_[window] = new WindowEntry(user_id);
 
+  // Remember the initial visibility of the window.
+  window_to_entry_[window]->set_show(window->IsVisible());
+
   // Set the window and the state observer.
   window->AddObserver(this);
   ash::wm::GetWindowState(window)->AddObserver(this);
 
   // Add all transient children to our set of windows. Note that the function
   // will add the children but not the owner to the transient children map.
   AddTransientOwnerRecursive(window, window);
 
   if (user_id != current_user_id_)
     SetWindowVisibility(window, false);
@@ skipping 15 matching lines @@
     return;
 
   // Check that we are not trying to transfer ownership of a minimized window.
   if (user_id != owner && ash::wm::GetWindowState(window)->IsMinimized())
     return;
 
   WindowToEntryMap::iterator it = window_to_entry_.find(window);
   it->second->set_show_for_user(user_id);
 
   // Show the window if the added user is the current one.
-  if (user_id == current_user_id_)
-    SetWindowVisibility(window, true);
-  else
+  if (user_id == current_user_id_) {
+    // Only show the window if it should be shown according to its state.
+    if (it->second->show())
+      SetWindowVisibility(window, true);
+  } else {
     SetWindowVisibility(window, false);
+  }
 }
 
 bool MultiUserWindowManager::AreWindowsSharedAmongUsers() {
   WindowToEntryMap::iterator it = window_to_entry_.begin();
   for (; it != window_to_entry_.end(); ++it) {
     if (it->second->owner() != it->second->show_for_user())
       return true;
   }
   return false;
 }
@@ skipping 348 matching lines @@
     // To prevent these commands from being recorded as any other commands, we
     // are suppressing any window entry changes while this is going on.
     // Instead of calling SetWindowVisible, only show gets called here since all
     // dependents have been shown previously already.
     base::AutoReset<bool> suppressor(&suppress_visibility_changes_, true);
     window->Show();
   }
 }
 
 }  // namespace chrome