Fixing drag and drop visibility issues of tabs on a visiting desktop

Fixing drag and drop visibility issues of tabs on a visiting desktop

A new browser will be created when a user drags a tab off a tab strip. This browser will automatically get the context of its parent.
When running in multi profile / multiple desktop mode, a browser can visit another user's desktop. In that case that tab will get the ownership of the original browser and made invisible since it belongs to an invisible user. This patch is transferring the visibility of the newly created browser to the current user. Note that this cannot be automatically done since usually browsers get created for "a user" and are automatically visible and owned by "that user" - not the current one. This case is special since it requires that the browser is created from the current user for another user.

While fixing this I have found one problem in the MultiUserWindowManager where the initial show state was not stored and taken into account on transferring to another desktop.

BUG=309793
TEST=unittest & visual test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232644

[Mr4D (OOO till 08-26), 2013-10-31 21:47:16]

Please have a look!

[sky, 2013-10-31 22:04:04]

https://codereview.chromium.org/55303003/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab_drag_controller.cc (right):

https://codereview.chromium.org/55303003/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab_drag_controller.cc:261: void
MoveBrowserToCurrentUser(Browser* browser) {
This feels wrong. Why do we have to special case every call site that is
creating a browser?

[sky, 2013-10-31 22:04:34]

I do get why you're doing this, but there should be a cleaner way than a slew of
ifdefs in every place that creates a browser.

[Mr4D (OOO till 08-26), 2013-11-01 03:13:45]

Sky, I have changed the logic to look at active events and open menus to
automatically present owned windows on the active desktop. I did make sure that
the browser wrench menu is still able to create browsers on a visiting desktop
as intended.

I removed the TabDragController changes.

Please have another look!

[sky, 2013-11-01 23:32:56]

LGTM

[commit-bot: I haz the power, 2013-11-01 23:37:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/60002

[commit-bot: I haz the power, 2013-11-02 01:32:53]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-02 01:45:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/60002

[commit-bot: I haz the power, 2013-11-02 01:57:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/460003

[commit-bot: I haz the power, 2013-11-02 03:31:40]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-02 06:00:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/850001

[commit-bot: I haz the power, 2013-11-02 07:32:10]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-02 13:39:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/850001

[commit-bot: I haz the power, 2013-11-02 15:03:17]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-02 15:46:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/1120001

[commit-bot: I haz the power, 2013-11-02 17:42:21]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-02 17:57:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/1120001

[commit-bot: I haz the power, 2013-11-02 19:36:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/1120001

[commit-bot: I haz the power, 2013-11-02 21:34:28]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-02 22:06:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/55303003/1120001

[commit-bot: I haz the power, 2013-11-02 23:53:29]

Change committed as 232644