Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 55303002: Unittest for Component updater throttles (Closed)

Created:
7 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 1 month ago
Reviewers:
waffles, Sorin Jianu
CC:
chromium-reviews
Visibility:
Public.

Description

Unittest for Component updater throttles Part of the on-demand feature see https://codereview.chromium.org/25713007/ for more context. BUG=none TEST=none R=sorin@chromium.org, waffles@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236892

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 2 3 5 chunks +94 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
Work in progress.
7 years, 1 month ago (2013-10-31 21:03:57 UTC) #1
Sorin Jianu
lgtm Thank you Carlos. I was thinking whether it would be worth testing that the ...
7 years, 1 month ago (2013-10-31 21:33:03 UTC) #2
cpu_(ooo_6.6-7.5)
Yeah, all of those will come.
7 years, 1 month ago (2013-11-01 23:35:22 UTC) #3
waffles
lgtm https://codereview.chromium.org/55303002/diff/1/chrome/browser/component_updater/test/component_updater_service_unittest.cc File chrome/browser/component_updater/test/component_updater_service_unittest.cc (right): https://codereview.chromium.org/55303002/diff/1/chrome/browser/component_updater/test/component_updater_service_unittest.cc#newcode1130 chrome/browser/component_updater/test/component_updater_service_unittest.cc:1130: // By requesting a throttle and deleting it ...
7 years, 1 month ago (2013-11-12 00:22:57 UTC) #4
cpu_(ooo_6.6-7.5)
7 years, 1 month ago (2013-11-23 01:07:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r236892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698