Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 553013002: Revert of Skia roll 87c4138:49e3199 (Closed)

Created:
6 years, 3 months ago by mtklein
Modified:
6 years, 3 months ago
CC:
chromium-reviews, fmalita_google_do_not_use, mtklein
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Skia roll 87c4138:49e3199 (patchset #1 id:1 of https://codereview.chromium.org/554293002/) Reason for revert: read the bot results wrong. we did break a test Original issue's description: > Skia roll 87c4138:49e3199 > > https://skia.googlesource.com/skia/+log/87c4138fae37ba6b7e4de7acc3fce19524d726ea..49e3199e638595d7e8b8bf41081eb9cac5daaa2d > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg > TBR=fmalita@google.com > > Failing tests are failing with and without this CL. > NOTRY=true > > Committed: https://chromium.googlesource.com/chromium/src/+/3903c20d4c27bfc0092ed9056d43f4837288ef60 TBR=fmalita@google.com,skia-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0f21991bc07973c7839abadcf32c5d2eb4262070 Cr-Commit-Position: refs/heads/master@{#293939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mtklein
Created Revert of Skia roll 87c4138:49e3199
6 years, 3 months ago (2014-09-09 14:40:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@google.com/553013002/1
6 years, 3 months ago (2014-09-09 14:40:23 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-09 14:40:25 UTC) #4
f(malita)
lgtm
6 years, 3 months ago (2014-09-09 14:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@google.com/553013002/1
6 years, 3 months ago (2014-09-09 14:42:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4bf7a683ab61226ccacd1a5657a3e51affe9e557
6 years, 3 months ago (2014-09-09 14:43:31 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f21991bc07973c7839abadcf32c5d2eb4262070
Cr-Commit-Position: refs/heads/master@{#293939}

Powered by Google App Engine
This is Rietveld 408576698