Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 552983003: Wait for the Bluetooth adapter to be present before starting pairing. (Closed)

Created:
6 years, 3 months ago by Zachary Kuznia
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Wait for the Bluetooth adapter to be present before starting pairing. BUG=None Committed: https://crrev.com/20e0b1a5f52f1cc0ab24becf9d6ec3d4ba84b7c7 Cr-Commit-Position: refs/heads/master@{#295207}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Patch Set 3 : Add missing OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M components/pairing/bluetooth_host_pairing_controller.h View 1 2 4 chunks +7 lines, -0 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 1 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nikita (slow)
lgtm https://codereview.chromium.org/552983003/diff/1/components/pairing/bluetooth_host_pairing_controller.cc File components/pairing/bluetooth_host_pairing_controller.cc (right): https://codereview.chromium.org/552983003/diff/1/components/pairing/bluetooth_host_pairing_controller.cc#newcode29 components/pairing/bluetooth_host_pairing_controller.cc:29: BluetoothHostPairingController::~BluetoothHostPairingController() {} Remove observer on dtor?
6 years, 3 months ago (2014-09-16 21:54:56 UTC) #2
Zachary Kuznia
https://codereview.chromium.org/552983003/diff/1/components/pairing/bluetooth_host_pairing_controller.cc File components/pairing/bluetooth_host_pairing_controller.cc (right): https://codereview.chromium.org/552983003/diff/1/components/pairing/bluetooth_host_pairing_controller.cc#newcode29 components/pairing/bluetooth_host_pairing_controller.cc:29: BluetoothHostPairingController::~BluetoothHostPairingController() {} On 2014/09/16 21:54:56, Nikita Kostylev wrote: > ...
6 years, 3 months ago (2014-09-16 22:06:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552983003/20001
6 years, 3 months ago (2014-09-16 22:07:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/14918)
6 years, 3 months ago (2014-09-16 23:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552983003/40001
6 years, 3 months ago (2014-09-16 23:31:32 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 83a94dadbf9afb4b33167ca0070bda11f35c65cc
6 years, 3 months ago (2014-09-17 01:23:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:23:33 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20e0b1a5f52f1cc0ab24becf9d6ec3d4ba84b7c7
Cr-Commit-Position: refs/heads/master@{#295207}

Powered by Google App Engine
This is Rietveld 408576698