Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: tests/corelib/uri_test.dart

Issue 552973003: Fix Uri.replace adding an empty authority by mistake. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/uri_test.dart
diff --git a/tests/corelib/uri_test.dart b/tests/corelib/uri_test.dart
index c2c8286c7e84e806b0ecdee496d6360aa53a6b62..7971256c10883d47091f05ed4251804376d89382 100644
--- a/tests/corelib/uri_test.dart
+++ b/tests/corelib/uri_test.dart
@@ -425,6 +425,11 @@ void testReplace() {
}
}
}
+
+ // Regression test, http://dartbug.com/20814
+ var uri = Uri.parse("/no-authorty/");
kasperl 2014/09/09 11:07:04 Is the typo intentional?
Lasse Reichstein Nielsen 2014/09/09 11:08:49 Nope, well spotted. It is, however, also complete
+ uri = uri.replace(fragment: "fragment");
+ Expect.isFalse(uri.hasAuthority);
}
main() {
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698