sdk/lib/core/uri.dart - Issue 552973003: Fix Uri.replace adding an empty authority by mistake.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/uri.dart

Issue 552973003: Fix Uri.replace adding an empty authority by mistake. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/core/uri.dart

diff --git a/sdk/lib/core/uri.dart b/sdk/lib/core/uri.dart

index 4027355d65445390e87dcde2013438f13e1f0b7f..c4cb508e2c05eec3cc3e78c35a01de1230c31b55 100644

--- a/sdk/lib/core/uri.dart

+++ b/sdk/lib/core/uri.dart

@@ -886,7 +886,7 @@ class Uri {

if (port != null) {

port = _makePort(port, scheme);

} else {

- port = this.port;

+ port = this._port;

if (schemeChanged) {

// The default port might have changed.

port = _makePort(port, scheme);

« no previous file with comments | « no previous file | tests/corelib/uri_test.dart » ('j') | tests/corelib/uri_test.dart » ('J')