Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 552963002: Simplify test locales in ui_unittests Framework (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplify test locales in Mac's ui_unittests Framework Mac creates a mini-framework in `ui_unittests Framework` so that ui tests can get a resource bundle without depending on the Chrome framework. The way it generated locale information was causing build flakes since two instances of repack_locales.py could be writing to out/../gen/repack. Tests always use en-US, so instead just do what iOS does and copy ui_test.pak to en.lproj/locale.pak and roll it into the mini-framework bundle. BUG=410468 Committed: https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54 Cr-Commit-Position: refs/heads/master@{#294052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M ui/base/ui_base_tests_bundle.gypi View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tapted
Hi Avi, please take a look. I've tested this in a clobber build; just building ...
6 years, 3 months ago (2014-09-09 08:55:32 UTC) #3
Avi (use Gerrit)
lgtm That's fine.
6 years, 3 months ago (2014-09-09 14:11:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/552963002/1
6 years, 3 months ago (2014-09-09 23:25:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5b46b6a3166fdccbde174e84c2f3f363ea1d08e4
6 years, 3 months ago (2014-09-10 00:36:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54 Cr-Commit-Position: refs/heads/master@{#294052}
6 years, 3 months ago (2014-09-10 03:57:00 UTC) #8
tapted
6 years, 3 months ago (2014-09-11 05:18:58 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/560993004/ by tapted@chromium.org.

The reason for reverting is: Bizarrely, this is causing valgrind on Snow Leopard
to pick up a
bunch of leaks from allocations within system libraries.
Reverting while I figure out how best to fix that.

BUG=413034.

Powered by Google App Engine
This is Rietveld 408576698