Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: public/platform/WebSourceBuffer.h

Issue 552943002: MSE: Start letting SourceBuffer begin to do initialization segment received algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased. Addressed philipj@'s PS5 comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediasource/SourceBufferList.cpp ('k') | public/platform/WebSourceBufferClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebSourceBuffer.h
diff --git a/public/platform/WebSourceBuffer.h b/public/platform/WebSourceBuffer.h
index 1f34a0c52ab9696ab3baf3b5f732cda54e8c0139..3c8dd14c609cf5c5b90f64cf13bc498c50805ba4 100644
--- a/public/platform/WebSourceBuffer.h
+++ b/public/platform/WebSourceBuffer.h
@@ -35,6 +35,8 @@
namespace blink {
+class WebSourceBufferClient;
+
class WebSourceBuffer {
public:
enum AppendMode {
@@ -43,6 +45,14 @@ public:
};
virtual ~WebSourceBuffer() { }
+
+ // This will only be called once and only with a non-null pointer to a
+ // client whose ownership is not transferred to this WebSourceBuffer.
+ virtual void setClient(WebSourceBufferClient*)
+ {
+ // FIXME: Remove default implementation once Chromium impl lands.
+ }
+
virtual bool setMode(AppendMode) = 0;
virtual WebTimeRanges buffered() = 0;
@@ -60,6 +70,8 @@ public:
// Set presentation timestamp for the end of append window.
virtual void setAppendWindowEnd(double) = 0;
+ // After this method is called, this WebSourceBuffer should never use the
+ // client pointer passed to setClient().
virtual void removedFromMediaSource() = 0;
};
« no previous file with comments | « Source/modules/mediasource/SourceBufferList.cpp ('k') | public/platform/WebSourceBufferClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698