MSE: Start letting SourceBuffer begin to do initialization segment received algorithm

public/platform/WebSourceBuffer.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebSourceBuffer_h
 #define WebSourceBuffer_h
 
 #include "WebTimeRange.h"
 
 namespace blink {
 
+class WebSourceBufferClient;
+
 class WebSourceBuffer {
 public:
     enum AppendMode {
         AppendModeSegments,
         AppendModeSequence
     };
 
     virtual ~WebSourceBuffer() { }
+
+    // This will only be called once and only with a valid pointer.

[philipj_slow, 2014/09/11 13:38:32]

Maybe say that it's never null, since valid is a bit vague and could mean just
not stale?

[wolenetz, 2014/09/11 21:41:17]

Done.

+    virtual void setClient(WebSourceBufferClient*)
+    {
+        // FIXME: Remove default implementation once Chromium impl lands.
+    }
+
     virtual bool setMode(AppendMode) = 0;
     virtual WebTimeRanges buffered() = 0;
 
     // Appends data and runs the segment parser loop algorithm.
     // The algorithm may update |*timestampOffset| if |timestampOffset| is not null.
     virtual void append(const unsigned char* data, unsigned length, double* timestampOffset) = 0;
 
     virtual void abort() = 0;
     virtual void remove(double start, double end) = 0;
     virtual bool setTimestampOffset(double) = 0;
 
     // Set presentation timestamp for the start of append window.
     virtual void setAppendWindowStart(double) = 0;
 
     // Set presentation timestamp for the end of append window.
     virtual void setAppendWindowEnd(double) = 0;
 
+    // The client passed to setClient() should never be called after this method

[philipj_slow, 2014/09/11 13:38:32]

I don't understand this comment. Does setClient() transfer ownership of the
WebSourceBufferClient to the WebSourceBuffer, but one is allowed to borrow a
reference until the removedFromMediaSource() call?

[wolenetz, 2014/09/11 21:41:17]

I've clarified this a bit more. I'm trying to indicate that there is no
ownership of the WebSourceBufferClient transferred to the WebSourceBuffer by
setClient(). setClient() passes a raw pointer. The WebSourceBuffer should not
use this raw pointer after removedFromMediaSource() is called; the pointer is
only 'valid' between setClient() and removedFromMediaSource(). WebSourceBuffer
does not own the client object.

[philipj_slow, 2014/09/12 08:45:28]

That's simple enough, and the updated comments are great, thanks!

+    // is called.
     virtual void removedFromMediaSource() = 0;
 };
 
 } // namespace blink
 
 #endif