chrome/browser/resources/options/search_engine_manager.js - Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager.js

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2

Patch Set: fixed assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/password_manager_list.js ('k') | chrome/browser/resources/options/search_engine_manager_engine_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager.js

diff --git a/chrome/browser/resources/options/search_engine_manager.js b/chrome/browser/resources/options/search_engine_manager.js

index c3e8971ad1ace2fc3c2d404f88bd45cd8eb70a00..ce31ef6918163782cd2125798876f2c1a896a934 100644

--- a/chrome/browser/resources/options/search_engine_manager.js

+++ b/chrome/browser/resources/options/search_engine_manager.js

@@ -62,7 +62,7 @@ cr.define('options', function() {

/**

* Sets up the given list as a search engine list

- * @param {cr.ui.List} list The list to set up.

+ * @param {HTMLElement} list The list to set up.

* @private

setUpList_: function(list) {

@@ -73,9 +73,9 @@ cr.define('options', function() {

/**

* Updates the search engine list with the given entries.

* @private

- * @param {Array} defaultEngines List of possible default search engines.

- * @param {Array} otherEngines List of other search engines.

- * @param {Array} keywords List of keywords from extensions.

+ * @param {!Array} defaultEngines List of possible default search engines.

+ * @param {!Array} otherEngines List of other search engines.

+ * @param {!Array} keywords List of keywords from extensions.

updateSearchEngineList_: function(defaultEngines, otherEngines, keywords) {

this.defaultsList_.dataModel = new ArrayDataModel(defaultEngines);