Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 552843004: Adding texture uploads without cache for YUV and ETC1 (Closed)

Created:
6 years, 3 months ago by sugoi1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Adding texture uploads without cache for YUV and ETC1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/0249ec267a7c4f31b1f19668c176c2e3e33b7e19

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -67 lines) Patch
M src/gpu/SkGr.cpp View 7 chunks +42 lines, -67 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
sugoi1
Here are the modifications discussed in last week's e-mail.
6 years, 3 months ago (2014-09-08 19:55:29 UTC) #2
bsalomon
lgtm, but do we need to add a test case for etc1 that sets the ...
6 years, 3 months ago (2014-09-08 20:56:14 UTC) #4
bsalomon
On 2014/09/08 20:56:14, bsalomon wrote: > lgtm, but do we need to add a test ...
6 years, 3 months ago (2014-09-08 21:18:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/552843004/1
6 years, 3 months ago (2014-09-09 15:05:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0249ec267a7c4f31b1f19668c176c2e3e33b7e19
6 years, 3 months ago (2014-09-09 15:12:37 UTC) #8
robertphillips
6 years, 3 months ago (2014-09-10 14:18:12 UTC) #9
Message was sent while issue was closed.
Testing that code path would be wise.

https://codereview.chromium.org/552843004/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/552843004/diff/1/src/gpu/SkGr.cpp#newcode141
src/gpu/SkGr.cpp:141: const SkBitmap& bm,
const GrTextureDesc&

Powered by Google App Engine
This is Rietveld 408576698