Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 552753002: Handle bionic's strerror_r in an ABI-compatible way. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle bionic's strerror_r in an ABI-compatible way. The previous fix in r291050 fixed source compatibility but broke ABI compatibility with older versions of bionic instead. Since older versions of bionic only provide the POSIX version of strerror_r we should instead make sure we always use that version. BUG= Committed: https://crrev.com/c35ed07fdef5741deb5a306ca838a80515399487 Cr-Commit-Position: refs/heads/master@{#293894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M base/safe_strerror_posix.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Torne
Hi again Brett, Looks like my previous change in https://codereview.chromium.org/491893002/ was the wrong fix as ...
6 years, 3 months ago (2014-09-08 10:50:43 UTC) #2
Torne
6 years, 3 months ago (2014-09-08 14:36:58 UTC) #4
Primiano Tucci (use gerrit)
Hyperbolic LGTM (This source file has more corner cases than what allowed by euclidean geometry, ...
6 years, 3 months ago (2014-09-08 15:58:03 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-08 19:58:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/552753002/1
6 years, 3 months ago (2014-09-08 20:28:40 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-09 04:31:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/552753002/1
6 years, 3 months ago (2014-09-09 07:25:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as c7c1067368fb5ec88519e84edf030a9fe538cddf
6 years, 3 months ago (2014-09-09 08:15:33 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c35ed07fdef5741deb5a306ca838a80515399487
Cr-Commit-Position: refs/heads/master@{#293894}

Powered by Google App Engine
This is Rietveld 408576698