Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 552743006: Exclude (Mac test) MenuControllerTest.OpenClose from valgrind running ui_unittests (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exclude (Mac test) MenuControllerTest.OpenClose from valgrind running ui_unittests It's tickling some strange leaks out of allocations in system libraries. TBR=glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=414191 Committed: https://crrev.com/7279fced4d4890c54ce2ac52879fa2bf2b471c0a Cr-Commit-Position: refs/heads/master@{#294791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/ui_unittests.gtest-memcheck.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Alexander, this one is being really tricksy. More details at http://crbug.com/414191
6 years, 3 months ago (2014-09-15 08:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552743006/1
6 years, 3 months ago (2014-09-15 08:22:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 608f0bb7528c36b063e9473d36430e48393a5b69
6 years, 3 months ago (2014-09-15 08:25:16 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7279fced4d4890c54ce2ac52879fa2bf2b471c0a Cr-Commit-Position: refs/heads/master@{#294791}
6 years, 3 months ago (2014-09-15 08:28:52 UTC) #6
Alexander Potapenko
6 years, 3 months ago (2014-09-15 13:38:43 UTC) #7
Message was sent while issue was closed.
On 2014/09/15 08:28:52, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7279fced4d4890c54ce2ac52879fa2bf2b471c0a
> Cr-Commit-Position: refs/heads/master@{#294791}

LGTM, thanks for taking care.

Powered by Google App Engine
This is Rietveld 408576698