Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552743004: Outset the stroke width when computing the bounds for drawing a stroked rect, or 1 if it's a hairli… (Closed)

Created:
6 years, 3 months ago by gw280
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Outset the stroke width when computing the bounds for drawing a stroked rect, or 1 if it's a hairline Adds a testcase for stroke rect bug R=reed1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/b3eba478d5bed5fb2b5f0f224738c8c292cebf36

Patch Set 1 #

Patch Set 2 : Updated patch set without erroneous gyp changes #

Patch Set 3 : Third time lucky? Let's try and get this right this time. #

Total comments: 1

Patch Set 4 : Use radius #

Total comments: 1

Patch Set 5 : SkScalarHalf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
A gm/clip_strokerect.cpp View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
gw280
6 years, 3 months ago (2014-09-09 02:19:12 UTC) #1
reed1
https://codereview.chromium.org/552743004/diff/40001/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/552743004/diff/40001/src/core/SkDraw.cpp#newcode823 src/core/SkDraw.cpp:823: ir.outset(paint.getStrokeWidth(), paint.getStrokeWidth()); stroke_width / 2 ?
6 years, 3 months ago (2014-09-09 13:05:49 UTC) #2
reed1
lgtm w/ nit https://codereview.chromium.org/552743004/diff/60001/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/552743004/diff/60001/src/core/SkDraw.cpp#newcode823 src/core/SkDraw.cpp:823: SkScalar radius = paint.getStrokeWidth() / 2; ...
6 years, 3 months ago (2014-09-09 18:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/552743004/80001
6 years, 3 months ago (2014-09-09 18:26:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 18:34:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as b3eba478d5bed5fb2b5f0f224738c8c292cebf36

Powered by Google App Engine
This is Rietveld 408576698