Source/modules/serviceworkers/NavigatorServiceWorker.cpp - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.cpp

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach ApplicationCacheHost during (Oilpan) finalization Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/NavigatorServiceWorker.cpp

diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.cpp b/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

index f929fe53236d83606eef4c4338be67143bf364cd..e7427042c04d70739ad026c52b8a36b670ff4f7d 100644

--- a/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

@@ -18,9 +18,7 @@ NavigatorServiceWorker::NavigatorServiceWorker(Navigator& navigator)

{

}

-NavigatorServiceWorker::~NavigatorServiceWorker()

+DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(NavigatorServiceWorker);

NavigatorServiceWorker* NavigatorServiceWorker::from(Document& document)

{

@@ -78,6 +76,7 @@ void NavigatorServiceWorker::trace(Visitor* visitor)

{

visitor->trace(m_serviceWorker);

WillBeHeapSupplement<Navigator>::trace(visitor);

+ DOMWindowProperty::trace(visitor);

}

} // namespace blink