Source/core/loader/appcache/ApplicationCache.h - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/appcache/ApplicationCache.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach ApplicationCacheHost during (Oilpan) finalization Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/appcache/ApplicationCache.h

diff --git a/Source/core/loader/appcache/ApplicationCache.h b/Source/core/loader/appcache/ApplicationCache.h

index 75f66106dafb2590fe06ae43b176997569acdc85..0f3860389abf2b8d7965c921ecb417ccad9f03c5 100644

--- a/Source/core/loader/appcache/ApplicationCache.h

+++ b/Source/core/loader/appcache/ApplicationCache.h

@@ -49,7 +49,7 @@ public:

{

return adoptRefWillBeNoop(new ApplicationCache(frame));

}

- virtual ~ApplicationCache() { ASSERT(!m_frame); }

+ virtual ~ApplicationCache();

virtual void willDestroyGlobalObjectInFrame() OVERRIDE;

@@ -74,6 +74,8 @@ public:

static const AtomicString& toEventType(ApplicationCacheHost::EventID);

+ virtual void trace(Visitor*) OVERRIDE;

private:

explicit ApplicationCache(LocalFrame*);