Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552733002: bindings: Cleans up V8{HTML,SVG}ElementWrapperFactory. (Closed)

Created:
6 years, 3 months ago by Yuki
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, arv+blink, blink-reviews-html_chromium.org, fs, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, gyuyoung.kim_webkit.org, f(malita), Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

bindings: Cleans up V8{HTML,SVG}ElementWrapperFactory. Removes unnecessary code around ElementWrapperFactory. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -117 lines) Patch
M Source/bindings/core/v8/CustomElementBinding.h View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/CustomElementBinding.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/CustomElementConstructorBuilder.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 4 chunks +4 lines, -13 lines 0 comments Download
M Source/build/scripts/make_element_factory.py View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/build/scripts/scripts.gni View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/build/scripts/scripts.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/build/scripts/templates/ElementWrapperFactory.h.tmpl View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/BUILD.gn View 4 chunks +0 lines, -6 lines 0 comments Download
M Source/core/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/core_generated.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
6 years, 3 months ago (2014-09-08 09:45:28 UTC) #2
haraken
LGTM!
6 years, 3 months ago (2014-09-08 13:42:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/552733002/1
6 years, 3 months ago (2014-09-08 13:51:13 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 13:54:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181558

Powered by Google App Engine
This is Rietveld 408576698