Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 552723003: If duration of media source is unknown then return NaN. (Closed)

Created:
6 years, 3 months ago by atsykhonia
Modified:
6 years, 3 months ago
Reviewers:
qinmin
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

If duration of media source is unknown then return NaN. According to spec http://www.w3schools.com/tags/av_prop_duration.asp, if no audio/video is set, NaN should be returned. When metadata is not available, duration is unknown then NaN is returned. R=qinmin@chromium.org Committed: https://crrev.com/536be704e6ff71001c7f402e18956204bf76f8bf Cr-Commit-Position: refs/heads/master@{#294131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 5 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qinmin
lgtm
6 years, 3 months ago (2014-09-09 21:54:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atsykhonia@yandex-team.ru/552723003/1
6 years, 3 months ago (2014-09-10 05:49:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 082d298e9c7150a5a05bb4a7d3f45604f050409d
6 years, 3 months ago (2014-09-10 06:58:36 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 07:03:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/536be704e6ff71001c7f402e18956204bf76f8bf
Cr-Commit-Position: refs/heads/master@{#294131}

Powered by Google App Engine
This is Rietveld 408576698