chrome/chrome_browser.gypi - Issue 552703002: Fix compilation on Windows with enable_printing=2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 552703002: Fix compilation on Windows with enable_printing=2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mon Sep 8 14:18:50 PDT 2014 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 13aa270fa0f8f0bec03c8f702514c8b37a41e1aa..7dcce243ac6840e530b479aa6da2dc5eff2f3c9b 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1854,8 +1854,6 @@

# Used on top of the "basic" sources when enable_printing == 1 (full).

'chrome_browser_full_printing_sources': [

- 'browser/local_discovery/privet_http_impl.cc',

- 'browser/local_discovery/privet_http_impl.h',

'browser/local_discovery/pwg_raster_converter.cc',

'browser/local_discovery/pwg_raster_converter.h',

'browser/printing/background_printing_manager.cc',

@@ -2384,6 +2382,8 @@

'browser/local_discovery/privet_device_resolver.h',

'browser/local_discovery/privet_http.cc',

'browser/local_discovery/privet_http.h',

+ 'browser/local_discovery/privet_http_impl.cc',

+ 'browser/local_discovery/privet_http_impl.h',

Lei Zhang 2014/09/08 21:31:43 nit: alphabetical order, which does mean these won

Vitaly Buka (NO REVIEWS) 2014/09/08 21:37:01 Done.

'browser/local_discovery/privet_http_asynchronous_factory.cc',

'browser/local_discovery/privet_http_asynchronous_factory.h',

'browser/local_discovery/privet_http_asynchronous_factory_mac.cc',

« no previous file with comments | « chrome/browser/ui/location_bar/origin_chip_info.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »