Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552703002: Fix compilation on Windows with enable_printing=2. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation on Windows with enable_printing=2. BUG=374321 NOTRY=true Committed: https://crrev.com/f537167a19728b508c8dcf192273d75b3a1726c7 Cr-Commit-Position: refs/heads/master@{#293820}

Patch Set 1 #

Patch Set 2 : Mon Sep 8 02:15:07 PDT 2014 #

Patch Set 3 : Mon Sep 8 02:23:13 PDT 2014 #

Patch Set 4 : Mon Sep 8 10:27:46 PDT 2014 #

Patch Set 5 : Mon Sep 8 10:32:47 PDT 2014 #

Total comments: 2

Patch Set 6 : Mon Sep 8 12:21:18 PDT 2014 #

Patch Set 7 : Mon Sep 8 14:18:50 PDT 2014 #

Total comments: 2

Patch Set 8 : Mon Sep 8 17:26:04 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -124 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 2 3 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_http.h View 1 2 3 4 5 6 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 3 4 5 6 6 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 3 4 5 6 20 chunks +94 lines, -87 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/location_bar/origin_chip_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_utility_printing_messages.h View 4 chunks +14 lines, -15 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-08 16:46:09 UTC) #2
Vitaly Buka (NO REVIEWS)
+jorgelo for chrome/common/chrome_utility_printing_messages.h and chrome/common/common_message_generator.h
6 years, 3 months ago (2014-09-08 17:33:40 UTC) #4
Lei Zhang
Looking good, but trybots failed compilation. https://codereview.chromium.org/552703002/diff/80001/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/552703002/diff/80001/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode400 chrome/browser/metrics/chrome_metrics_service_client.cc:400: // Android has ...
6 years, 3 months ago (2014-09-08 18:50:35 UTC) #5
Jorge Lucangeli Obes
messages lgtm, seems to just move stuff around.
6 years, 3 months ago (2014-09-08 19:51:57 UTC) #6
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/552703002/diff/80001/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/552703002/diff/80001/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode400 chrome/browser/metrics/chrome_metrics_service_client.cc:400: // Android has no service process. On 2014/09/08 18:50:35, ...
6 years, 3 months ago (2014-09-08 21:21:46 UTC) #7
Lei Zhang
lgtm with green trybots https://codereview.chromium.org/552703002/diff/120001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/552703002/diff/120001/chrome/chrome_browser.gypi#newcode2386 chrome/chrome_browser.gypi:2386: 'browser/local_discovery/privet_http_impl.h', nit: alphabetical order, which ...
6 years, 3 months ago (2014-09-08 21:31:43 UTC) #8
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/552703002/diff/120001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/552703002/diff/120001/chrome/chrome_browser.gypi#newcode2386 chrome/chrome_browser.gypi:2386: 'browser/local_discovery/privet_http_impl.h', On 2014/09/08 21:31:43, Lei Zhang wrote: > nit: ...
6 years, 3 months ago (2014-09-08 21:37:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/552703002/140001
6 years, 3 months ago (2014-09-08 21:40:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/552703002/160001
6 years, 3 months ago (2014-09-09 00:28:29 UTC) #16
commit-bot: I haz the power
Committed patchset #8 (id:160001) as 79ceaaf8dbbc9ff58070457fbc2f57d18ab6d55a
6 years, 3 months ago (2014-09-09 00:33:32 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:13 UTC) #18
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/f537167a19728b508c8dcf192273d75b3a1726c7
Cr-Commit-Position: refs/heads/master@{#293820}

Powered by Google App Engine
This is Rietveld 408576698