Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 552693002: ServiceWorker: Make GetOrCreateRegistrationHandle for refactoring (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Make GetOrCreateRegistrationHandle for refactoring BUG=399533 TEST=n/a (no behavioral change) NOTRY=true Committed: https://crrev.com/21d4e036e1faebe94ab436b90b1a772abf8cf051 Cr-Commit-Position: refs/heads/master@{#293708}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 3 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
nhiroki
horo-san, can you review this simple refactoring patch? As I'd like to use GetOrCreateRegistrationHandle() from ...
6 years, 3 months ago (2014-09-08 06:36:40 UTC) #2
horo
lgtm
6 years, 3 months ago (2014-09-08 07:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/552693002/1
6 years, 3 months ago (2014-09-08 10:48:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/8627)
6 years, 3 months ago (2014-09-08 10:53:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/552693002/20001
6 years, 3 months ago (2014-09-08 11:08:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11812)
6 years, 3 months ago (2014-09-08 12:10:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/552693002/20001
6 years, 3 months ago (2014-09-08 12:12:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3de5aec754d4e270564c09a744d59e560a3ef435
6 years, 3 months ago (2014-09-08 12:24:26 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21d4e036e1faebe94ab436b90b1a772abf8cf051
Cr-Commit-Position: refs/heads/master@{#293708}

Powered by Google App Engine
This is Rietveld 408576698