content/browser/web_contents/web_contents_impl_unittest.cc - Issue 552683004: Fix IsRenderFrameLive and use it in RenderFrameHostManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 552683004: Fix IsRenderFrameLive and use it in RenderFrameHostManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix OpenURLSubframe test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index f34a093c3ae5f0032b29ccca99e72486c2c59eb6..46c9168aa429e15b50144f38653d90fcc3b7cc69 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -574,8 +574,9 @@ TEST_F(WebContentsImplTest, CrossSiteBoundariesAfterCrash) {

EXPECT_FALSE(contents()->cross_navigation_pending());

EXPECT_EQ(orig_rfh->GetRenderViewHost(), contents()->GetRenderViewHost());

- // Crash the renderer.

+ // Simulate a renderer crash.

orig_rfh->GetRenderViewHost()->set_render_view_created(false);

+ orig_rfh->set_render_frame_created(false);

// Navigate to new site. We should not go into PENDING.

const GURL url2("http://www.yahoo.com");

« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | no next file » | no next file with comments »