content/browser/site_per_process_browsertest.cc - Issue 552683004: Fix IsRenderFrameLive and use it in RenderFrameHostManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 552683004: Fix IsRenderFrameLive and use it in RenderFrameHostManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix OpenURLSubframe test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/site_per_process_browsertest.cc

diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc

index cf491b6c5aac917b30575eea2a105e530d271b1b..a9ee3460839216fe0ffad991f2afe97d5742c52c 100644

--- a/content/browser/site_per_process_browsertest.cc

+++ b/content/browser/site_per_process_browsertest.cc

@@ -330,6 +330,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, DISABLED_CrashSubframe) {

EXPECT_EQ(main_url, root->current_url());

EXPECT_EQ(cross_site_url, child->current_url());

+ EXPECT_TRUE(

+ child->current_frame_host()->render_view_host()->IsRenderViewLive());

+ EXPECT_TRUE(child->current_frame_host()->IsRenderFrameLive());

// Crash the subframe process.

RenderProcessHost* root_process = root->current_frame_host()->GetProcess();

RenderProcessHost* child_process = child->current_frame_host()->GetProcess();

@@ -346,6 +350,11 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, DISABLED_CrashSubframe) {

EXPECT_EQ(main_url, root->current_url());

EXPECT_EQ(GURL(), child->current_url());

+ EXPECT_FALSE(

+ child->current_frame_host()->render_view_host()->IsRenderViewLive());

+ EXPECT_FALSE(child->current_frame_host()->IsRenderFrameLive());

+ EXPECT_FALSE(child->current_frame_host()->render_frame_created_);

// Now crash the top-level page to clear the child frame.

{

RenderProcessHostWatcher crash_observer(