Added UseCounter for XML external DTD.

Added UseCounter for XML external DTD.

BUG=367689
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181602

[tasak, 2014-09-08 05:58:24]

Patchset #1 (id:1) has been deleted

[tasak, 2014-09-08 06:00:02]

tasak@google.com changed reviewers:
+ kouhei@chromium.org

[tasak, 2014-09-08 06:00:03]

Would you review this CL?

[kouhei (in TOK), 2014-09-08 17:07:58]

https://codereview.chromium.org/552673002/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/552673002/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:498: XMLExternalDTD = 527,
openFunc is also used from xinclude and schema. Schema loading is disabled in
Blink, but xinclude may be not.

Let's use a generic name here, like XMLExternalResourceLoad.

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
File Source/core/xml/parser/XMLDocumentParser.cpp (right):

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
Source/core/xml/parser/XMLDocumentParser.cpp:632:
UseCounter::count(XMLDocumentParserScope::currentFetcher->document(),
UseCounter::XMLExternalDTD);
Let's move this down.

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
Source/core/xml/parser/XMLDocumentParser.cpp:661: 
to here.

[kouhei (in TOK), 2014-09-08 23:33:32]

lgtm once above are addressed. Remember to update histograms.xml after this
lands.

[tasak, 2014-09-09 03:07:07]

Thank you for reviewing.

https://codereview.chromium.org/552673002/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/552673002/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:498: XMLExternalDTD = 527,
On 2014/09/08 17:07:58, kouhei wrote:
> openFunc is also used from xinclude and schema. Schema loading is disabled in
> Blink, but xinclude may be not.
> 
> Let's use a generic name here, like XMLExternalResourceLoad.

I see.
Done.

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
File Source/core/xml/parser/XMLDocumentParser.cpp (right):

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
Source/core/xml/parser/XMLDocumentParser.cpp:632:
UseCounter::count(XMLDocumentParserScope::currentFetcher->document(),
UseCounter::XMLExternalDTD);
On 2014/09/08 17:07:58, kouhei wrote:
> Let's move this down.

Done.

https://codereview.chromium.org/552673002/diff/20001/Source/core/xml/parser/X...
Source/core/xml/parser/XMLDocumentParser.cpp:661: 
On 2014/09/08 17:07:58, kouhei wrote:
> to here.

Done.
Thanks.

[tasak, 2014-09-09 03:08:13]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[haraken, 2014-09-09 03:19:52]

LGTM

[tasak, 2014-09-09 03:20:31]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-09-09 03:20:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tasak@google.com/552673002/40001

[commit-bot: I haz the power, 2014-09-09 04:14:17]

Committed patchset #2 (id:40001) as 181602