Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: Source/platform/mediastream/MediaStreamComponent.h

Issue 552653005: Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor to oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/mediastream/MediaStreamComponent.h
diff --git a/Source/platform/mediastream/MediaStreamComponent.h b/Source/platform/mediastream/MediaStreamComponent.h
index 084c623494f8fce967f1d1b6faa3e1375ce74bbd..43bc010dc428198cd348598ed1f7a18724bd9964 100644
--- a/Source/platform/mediastream/MediaStreamComponent.h
+++ b/Source/platform/mediastream/MediaStreamComponent.h
@@ -33,9 +33,9 @@
#define MediaStreamComponent_h
#include "platform/audio/AudioSourceProvider.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
#include "wtf/ThreadingPrimitives.h"
#include "wtf/text/WTFString.h"
@@ -44,15 +44,15 @@ namespace blink {
class MediaStreamSource;
class WebAudioSourceProvider;
-class PLATFORM_EXPORT MediaStreamComponent : public RefCounted<MediaStreamComponent> {
+class PLATFORM_EXPORT MediaStreamComponent FINAL : public GarbageCollectedFinalized<MediaStreamComponent> {
public:
class ExtraData {
public:
virtual ~ExtraData() { }
};
- static PassRefPtr<MediaStreamComponent> create(PassRefPtr<MediaStreamSource>);
- static PassRefPtr<MediaStreamComponent> create(const String& id, PassRefPtr<MediaStreamSource>);
+ static MediaStreamComponent* create(MediaStreamSource*);
+ static MediaStreamComponent* create(const String& id, MediaStreamSource*);
MediaStreamSource* source() const { return m_source.get(); }
@@ -69,8 +69,11 @@ public:
ExtraData* extraData() const { return m_extraData.get(); }
void setExtraData(PassOwnPtr<ExtraData> extraData) { m_extraData = extraData; }
+ void trace(Visitor*);
+ void dispose();
+
private:
- MediaStreamComponent(const String& id, PassRefPtr<MediaStreamSource>);
+ MediaStreamComponent(const String& id, MediaStreamSource*);
#if ENABLE(WEB_AUDIO)
// AudioSourceProviderImpl wraps a WebAudioSourceProvider::provideInput()
@@ -99,14 +102,14 @@ private:
AudioSourceProviderImpl m_sourceProvider;
#endif // ENABLE(WEB_AUDIO)
- RefPtr<MediaStreamSource> m_source;
+ Member<MediaStreamSource> m_source;
String m_id;
bool m_enabled;
bool m_muted;
OwnPtr<ExtraData> m_extraData;
};
-typedef Vector<RefPtr<MediaStreamComponent> > MediaStreamComponentVector;
+typedef HeapVector<Member<MediaStreamComponent> > MediaStreamComponentVector;
} // namespace blink
« no previous file with comments | « Source/platform/exported/WebMediaStreamTrack.cpp ('k') | Source/platform/mediastream/MediaStreamComponent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698