Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 552643002: Move MockBookmarkModelObserver into bookmarks namespace. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, sdefresne, blundell, nshaik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move MockBookmarkModelObserver into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org TBR=joaodasilva@chromium.org Committed: https://crrev.com/1e542cb0bf4e4a77afc54fa70a4f20e73b753bca Cr-Commit-Position: refs/heads/master@{#293756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/test/mock_bookmark_model_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/test/mock_bookmark_model_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
6 years, 3 months ago (2014-09-08 02:04:18 UTC) #1
sky
LGTM
6 years, 3 months ago (2014-09-08 15:53:31 UTC) #2
tfarina
TBRing Joao for components/policy change.
6 years, 3 months ago (2014-09-08 16:09:52 UTC) #4
Joao da Silva
policy lgtm
6 years, 3 months ago (2014-09-08 16:10:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/552643002/1
6 years, 3 months ago (2014-09-08 16:11:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 97943fb963b7732744b6c2b8c0fe3717bb315dae
6 years, 3 months ago (2014-09-08 18:07:18 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e542cb0bf4e4a77afc54fa70a4f20e73b753bca
Cr-Commit-Position: refs/heads/master@{#293756}

Powered by Google App Engine
This is Rietveld 408576698