Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 552633004: Fixed an uninitialized variable in the AnalysisCanvas. (Closed)

Created:
6 years, 3 months ago by hendrikw
Modified:
6 years, 3 months ago
Reviewers:
vmpstr, Justin Novosad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed an uninitialized variable in the AnalysisCanvas. This can only occur when we haven't drawn anything and as a result the color_ member needs to be initialized to transparent. BUG=412377 Committed: https://crrev.com/4b2c60f37cedebd465c7ba897384b208a0a27c08 Cr-Commit-Position: refs/heads/master@{#294217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M skia/ext/analysis_canvas.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hendrikw
Please review this, thanks!
6 years, 3 months ago (2014-09-10 00:18:51 UTC) #2
vmpstr
lgtm, please format the description to be 72 col
6 years, 3 months ago (2014-09-10 00:20:58 UTC) #3
Justin Novosad
On 2014/09/10 00:20:58, vmpstr wrote: > lgtm, please format the description to be 72 col ...
6 years, 3 months ago (2014-09-10 18:00:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hendrikw@chromium.org/552633004/1
6 years, 3 months ago (2014-09-10 18:26:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 48a523bd18168c2766eb888956dd9c777f5f9780
6 years, 3 months ago (2014-09-10 20:35:47 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:40:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b2c60f37cedebd465c7ba897384b208a0a27c08
Cr-Commit-Position: refs/heads/master@{#294217}

Powered by Google App Engine
This is Rietveld 408576698