Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 552433002: dbus: Introduce util_unittest.cc (Closed)

Created:
6 years, 3 months ago by armansito
Modified:
6 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

dbus: Introduce util_unittest.cc This CL introduces util_unittest.cc, which acts as a place for current and future functions in util.h. BUG=411108 Committed: https://crrev.com/d6613735f5bbe340269ac00dfecf1a32486c37b4 Cr-Commit-Position: refs/heads/master@{#293793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M dbus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/dbus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A dbus/util_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
armansito
6 years, 3 months ago (2014-09-06 01:27:29 UTC) #2
satorux1
lgtm LGTM. Thank you for adding this.
6 years, 3 months ago (2014-09-08 07:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/552433002/1
6 years, 3 months ago (2014-09-08 07:14:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6279)
6 years, 3 months ago (2014-09-08 09:16:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/552433002/1
6 years, 3 months ago (2014-09-08 20:36:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as c96d555c02c9f080655a4653bf4f986f823ffd91
6 years, 3 months ago (2014-09-08 21:55:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6613735f5bbe340269ac00dfecf1a32486c37b4
Cr-Commit-Position: refs/heads/master@{#293793}

Powered by Google App Engine
This is Rietveld 408576698