Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3466)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 55243005: Implement learn more bubble on views. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index bd9c2f9c2c0130422bac02160e92028437a08adb..5121a135276ce9a5275b2615bae76f1f0af265dd 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -455,8 +455,8 @@ scoped_ptr<DialogNotification> GetWalletError(
l10n_util::GetStringUTF16(error_ids))));
if (error_code) {
- notification->set_tooltip_text(
- l10n_util::GetStringFUTF16(IDS_AUTOFILL_WALLET_ERROR_CODE_TOOLTIP,
+ notification->set_learn_more_text(
+ l10n_util::GetStringFUTF16(IDS_AUTOFILL_WALLET_ERROR_CODE_LEARN_MORE,
base::IntToString16(error_code)));
}
@@ -775,8 +775,8 @@ string16 AutofillDialogControllerImpl::SaveLocallyText() const {
return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_SAVE_LOCALLY_CHECKBOX);
}
-string16 AutofillDialogControllerImpl::SaveLocallyTooltip() const {
- return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_SAVE_LOCALLY_TOOLTIP);
+string16 AutofillDialogControllerImpl::SaveLocallyLearnMoreText() const {
+ return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_SAVE_LOCALLY_LEARN_MORE);
}
string16 AutofillDialogControllerImpl::LegalDocumentsText() {
@@ -1635,10 +1635,12 @@ bool AutofillDialogControllerImpl::FieldControlsIcons(
return type == CREDIT_CARD_NUMBER;
}
-string16 AutofillDialogControllerImpl::TooltipForField(ServerFieldType type)
- const {
- if (type == PHONE_HOME_WHOLE_NUMBER || type == PHONE_BILLING_WHOLE_NUMBER)
- return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_TOOLTIP_PHONE_NUMBER);
+string16 AutofillDialogControllerImpl::LearnMoreTextForField(
+ ServerFieldType type) const {
+ if (type == PHONE_HOME_WHOLE_NUMBER || type == PHONE_BILLING_WHOLE_NUMBER) {
+ return l10n_util::GetStringUTF16(
+ IDS_AUTOFILL_DIALOG_LEARN_MORE_PHONE_NUMBER);
+ }
return string16();
}
@@ -2018,9 +2020,9 @@ std::vector<DialogNotification> AutofillDialogControllerImpl::
DialogNotification notification(
DialogNotification::WALLET_USAGE_CONFIRMATION,
text);
- notification.set_tooltip_text(
+ notification.set_learn_more_text(
l10n_util::GetStringUTF16(
- IDS_AUTOFILL_DIALOG_SAVE_IN_WALLET_TOOLTIP));
+ IDS_AUTOFILL_DIALOG_SAVE_IN_WALLET_LEARN_MORE));
notification.set_checked(IsPayingWithWallet());
notifications.push_back(notification);
}

Powered by Google App Engine
This is Rietveld 408576698