Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 552423003: PPAPI: Make CallWhileUnlocked more permissive. (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Make CallWhileUnlocked more permissive. Prior to this patch, CallWhileUnlocked required its parameters' types to be perfect matches to the types in the function pointer it's meant to invoke. This is counter to programmers' usual expectations for function calls, since the compiler will usually do safe casts like add const or promoting integral types. This just adds template params to CallWhileUnlocked so that any call with the appropriate number of parameters will be a template match. The compiler will still decide if there is a valid implicit conversion, so this is still safe in the sense that mismatched params still won't compile. BUG=160925 Committed: https://crrev.com/36e91cd9ac1516a202ab09cc5ea98781c84db0d8 Cr-Commit-Position: refs/heads/master@{#294405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M ppapi/proxy/ppp_content_decryptor_private_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppp_printing_proxy.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ppapi/proxy/video_capture_resource.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.h View 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmichael (off chromium)
6 years, 3 months ago (2014-09-11 15:58:33 UTC) #2
teravest
lgtm This is much better.
6 years, 3 months ago (2014-09-11 16:06:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552423003/1
6 years, 3 months ago (2014-09-11 16:09:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 106d4fdf5be4870bdf4da596137694c011b03f86
6 years, 3 months ago (2014-09-11 16:58:45 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 17:03:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36e91cd9ac1516a202ab09cc5ea98781c84db0d8
Cr-Commit-Position: refs/heads/master@{#294405}

Powered by Google App Engine
This is Rietveld 408576698