Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: remoting/webapp/client_screen.js

Issue 552403004: Interfaceify ClientPlugin in preparation for mocking it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed interfaces. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/client_screen.js
diff --git a/remoting/webapp/client_screen.js b/remoting/webapp/client_screen.js
index e31bf652b582bb1419dd37971b93ea24fdc6a95e..c70c51e16ce92773b35aa8799a42017ba9a450fe 100644
--- a/remoting/webapp/client_screen.js
+++ b/remoting/webapp/client_screen.js
@@ -13,8 +13,8 @@
var remoting = remoting || {};
/**
- * @type {remoting.SessionConnector} The connector object, set when a connection
- * is initiated.
+ * @type {remoting.SessionConnector} The connector object, set when a
+ * connection is initiated.
*/
remoting.connector = null;
@@ -280,7 +280,8 @@ remoting.connectMe2MeHostVersionAcknowledged_ = function(host) {
remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
onPinFetched(pin);
if (/** @type {boolean} */(rememberPinCheckbox.checked)) {
- remoting.connector.pairingRequested = true;
+ /** @type {boolean} */
+ remoting.pairingRequested = true;
}
} else {
remoting.setMode(remoting.AppMode.HOME);
@@ -328,7 +329,7 @@ remoting.onConnected = function(clientSession) {
remoting.hangoutSessionEvents.sessionStateChanged,
remoting.ClientSession.State.CONNECTED
);
- if (remoting.connector.pairingRequested) {
+ if (remoting.pairingRequested) {
/**
* @param {string} clientId
* @param {string} sharedSecret
@@ -382,7 +383,7 @@ remoting.onExtensionMessage = function(type, data) {
*/
remoting.ensureSessionConnector_ = function() {
if (!remoting.connector) {
- remoting.connector = new remoting.SessionConnector(
+ remoting.connector = remoting.SessionConnector.factory.createConnector(
document.getElementById('video-container'),
remoting.onConnected,
showConnectError_, remoting.onExtensionMessage);

Powered by Google App Engine
This is Rietveld 408576698