Interfaceify ClientPlugin in preparation for mocking it.

remoting/webapp/session_connector.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Connect set-up state machine for Me2Me and IT2Me
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @param {HTMLElement} clientContainer Container element for the client view.
  * @param {function(remoting.ClientSession):void} onConnected Callback on
  *     success.
  * @param {function(remoting.Error):void} onError Callback on error.
  * @param {function(string, string):boolean} onExtensionMessage The handler for
  *     protocol extension messages. Returns true if a message is recognized;
  *     false otherwise.
  * @constructor
+ * @implements {remoting.SessionConnectorInterface}
  */
 remoting.SessionConnector = function(clientContainer, onConnected, onError,
                                      onExtensionMessage) {
   /**
    * @type {HTMLElement}
    * @private
    */
   this.clientContainer_ = clientContainer;
 
   /**
@@ skipping 48 matching lines @@
   // Initialize/declare per-connection state.
   this.reset();
 };
 
 /**
  * Reset the per-connection state so that the object can be re-used for a
  * second connection. Note the none of the shared WCS state is reset.
  */
 remoting.SessionConnector.prototype.reset = function() {
   /**
-   * Set to true to indicate that the user requested pairing when entering
-   * their PIN for a Me2Me connection.
-   *
-   * @type {boolean}
-   */
-  this.pairingRequested = false;
-
-  /**
    * String used to identify the host to which to connect. For IT2Me, this is
    * the first 7 digits of the access code; for Me2Me it is the host identifier.
    *
    * @type {string}
    * @private
    */
   this.hostId_ = '';
 
   /**
    * For paired connections, the client id of this device, issued by the host.
@@ skipping 323 matching lines @@
     if (host && host.data && host.data.jabberId && host.data.publicKey) {
       this.hostJid_ = host.data.jabberId;
       this.hostPublicKey_ = host.data.publicKey;
       this.hostDisplayName_ = this.hostJid_.split('/')[0];
       this.createSession_();
       return;
     } else {
       console.error('Invalid "support-hosts" response from server.');
     }
   } else {
-    this.onError_(this.translateSupportHostsError(xhr.status));
+    this.onError_(this.translateSupportHostsError_(xhr.status));
   }
 };
 
 /**
  * Creates ClientSession object.
  */
 remoting.SessionConnector.prototype.createSession_ = function() {
   // In some circumstances, the WCS <iframe> can get reloaded, which results
   // in a new clientJid and a new callback. In this case, remove the old
   // client plugin before instantiating a new one.
@@ skipping 109 matching lines @@
   }
   this.onError_(remoting.Error.HOST_IS_OFFLINE);
 };
 
 /**
  * @param {number} error An HTTP error code returned by the support-hosts
  *     endpoint.
  * @return {remoting.Error} The equivalent remoting.Error code.
  * @private
  */
-remoting.SessionConnector.prototype.translateSupportHostsError =
+remoting.SessionConnector.prototype.translateSupportHostsError_ =
     function(error) {
   switch (error) {
     case 0: return remoting.Error.NETWORK_FAILURE;
     case 404: return remoting.Error.INVALID_ACCESS_CODE;
     case 502: // No break
     case 503: return remoting.Error.SERVICE_UNAVAILABLE;
     default: return remoting.Error.UNEXPECTED;
   }
 };
 
 /**
  * Normalize the access code entered by the user.
  *
  * @param {string} accessCode The access code, as entered by the user.
  * @return {string} The normalized form of the code (whitespace removed).
+ * @private
  */
 remoting.SessionConnector.prototype.normalizeAccessCode_ =
     function(accessCode) {
   // Trim whitespace.
   return accessCode.replace(/\s/g, '');
 };
+
+
+/**
+ * @constructor
+ * @implements {remoting.SessionConnectorFactory}
+ */
+remoting.DefaultSessionConnectorFactory = function() {
+};
+
+/**
+ * @param {HTMLElement} clientContainer Container element for the client view.
+ * @param {function(remoting.ClientSession):void} onConnected Callback on
+ *     success.
+ * @param {function(remoting.Error):void} onError Callback on error.
+ * @param {function(string, string):boolean} onExtensionMessage The handler for
+ *     protocol extension messages. Returns true if a message is recognized;
+ *     false otherwise.
+ */
+remoting.DefaultSessionConnectorFactory.prototype.createConnector =
+    function(clientContainer, onConnected, onError, onExtensionMessage) {
+  return new remoting.SessionConnector(
+      clientContainer, onConnected, onError, onExtensionMessage);
+};
+
+/**
+ * @type {remoting.SessionConnectorFactory}
+ */
+remoting.SessionConnector.factory =
+    new remoting.DefaultSessionConnectorFactory();