Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552393003: Hide delete-profile checkbox when profile deletion is forbidden. (Closed)

Created:
6 years, 3 months ago by haitaol1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hide delete-profile checkbox when profile deletion is forbidden. BUG=408446, 413226 TBR=tim@chromium.org Committed: https://crrev.com/d0f399aaf2f29070067d726f301b8b2a06513c36 Cr-Commit-Position: refs/heads/master@{#294471}

Patch Set 1 #

Patch Set 2 : check existence of checkbox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
haitaol1
6 years, 3 months ago (2014-09-09 19:45:22 UTC) #2
Nicolas Zea
LGTM, but I don't think I'm an owner of the resources folder.
6 years, 3 months ago (2014-09-09 19:48:33 UTC) #3
haitaol1
+tim for owner review
6 years, 3 months ago (2014-09-09 20:04:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/552393003/1
6 years, 3 months ago (2014-09-10 17:42:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/12805)
6 years, 3 months ago (2014-09-10 19:04:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552393003/1
6 years, 3 months ago (2014-09-11 17:25:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13290)
6 years, 3 months ago (2014-09-11 18:57:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552393003/20001
6 years, 3 months ago (2014-09-11 19:05:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c5592fe5cf822785f25252b18a4648776e08837d
6 years, 3 months ago (2014-09-11 21:39:25 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d0f399aaf2f29070067d726f301b8b2a06513c36 Cr-Commit-Position: refs/heads/master@{#294471}
6 years, 3 months ago (2014-09-11 21:48:15 UTC) #17
Dan Beam
6 years, 3 months ago (2014-09-11 22:52:34 UTC) #19
Message was sent while issue was closed. 
owners lgtm

Powered by Google App Engine
This is Rietveld 408576698