Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 552373004: Dismissing suggestion popup if options menu is invoked. (Closed)

Created:
6 years, 3 months ago by ankit
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Dismissing suggestion popup if options menu is invoked. Currently if suggestion popup is visible and options menu is invoked from hardware options button then in that case suggestion popup and options menu are overlapping. Added code to dismiss suggestion popup if options menu is shown. BUG=412757 Committed: https://crrev.com/40aea5fe9465461152b40364306cbaab82552dac Cr-Commit-Position: refs/heads/master@{#294575}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
ankit
@Bernhard PTAL
6 years, 3 months ago (2014-09-10 13:22:50 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/552373004/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java File chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java (right): https://codereview.chromium.org/552373004/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java#newcode284 chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java:284: if (mToolbar != null) mToolbar.hideSuggestions(); If this is the ...
6 years, 3 months ago (2014-09-10 13:36:55 UTC) #3
Bernhard Bauer
Thanks for the explanation on the bug. LGTM
6 years, 3 months ago (2014-09-12 10:30:00 UTC) #4
ankit
On 2014/09/12 10:30:00, Bernhard Bauer wrote: > Thanks for the explanation on the bug. > ...
6 years, 3 months ago (2014-09-12 10:32:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552373004/1
6 years, 3 months ago (2014-09-12 10:33:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2f701ebfb7f71ae708e6da0ad3e8b97c6f417eb2
6 years, 3 months ago (2014-09-12 11:35:53 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 11:38:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40aea5fe9465461152b40364306cbaab82552dac
Cr-Commit-Position: refs/heads/master@{#294575}

Powered by Google App Engine
This is Rietveld 408576698