Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 552373003: Owners for Net.HttpAuth* histograms (Closed)

Created:
6 years, 3 months ago by cbentzel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Owners for Net.HttpAuth* histograms Committed: https://crrev.com/9888f45e041fee3a04ce4f641bc56e245f1411a0 Cr-Commit-Position: refs/heads/master@{#294066}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add owners section back into HttpAuthResource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
cbentzel
6 years, 3 months ago (2014-09-09 18:02:15 UTC) #2
asanka
lgtm
6 years, 3 months ago (2014-09-09 18:02:54 UTC) #3
Alexei Svitkine (slow)
lgtm % comment https://codereview.chromium.org/552373003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/552373003/diff/1/tools/metrics/histograms/histograms.xml#oldcode15447 tools/metrics/histograms/histograms.xml:15447: - <owner>Please list the metric's owners. ...
6 years, 3 months ago (2014-09-09 18:04:31 UTC) #4
cbentzel
Thanks https://codereview.chromium.org/552373003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/552373003/diff/1/tools/metrics/histograms/histograms.xml#oldcode15447 tools/metrics/histograms/histograms.xml:15447: - <owner>Please list the metric's owners. Add more ...
6 years, 3 months ago (2014-09-09 18:29:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/552373003/20001
6 years, 3 months ago (2014-09-09 18:39:38 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-10 00:54:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/552373003/20001
6 years, 3 months ago (2014-09-10 01:09:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f90cb0960a7a8133abc5967a62442621989bfe82
6 years, 3 months ago (2014-09-10 01:30:17 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9888f45e041fee3a04ce4f641bc56e245f1411a0
Cr-Commit-Position: refs/heads/master@{#294066}

Powered by Google App Engine
This is Rietveld 408576698