Issue 552363002: BlockingPool is flushed in DeviceOAuth2TokenServiceTest to prevent memory leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552363002: BlockingPool is flushed in DeviceOAuth2TokenServiceTest to prevent memory leaks. (Closed)

Created:
6 years, 3 months ago by ygorshenin1

Modified:
6 years, 3 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

BlockingPool is flushed in DeviceOAuth2TokenServiceTest to prevent memory leaks. BUG=381584 TEST=unit_tests:DeviceOAuth2TokenServiceTest.* Committed: https://crrev.com/65112b163035ac2a166f78d36f6701b23d624957 Cr-Commit-Position: refs/heads/master@{#294158}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/552363002/1

6 years, 3 months ago (2014-09-10 10:54:14 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 24896245ff58803f6920d982d043d680770a352a

6 years, 3 months ago (2014-09-10 11:49:01 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 11:51:29 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/65112b163035ac2a166f78d36f6701b23d624957
Cr-Commit-Position: refs/heads/master@{#294158}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages