Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 552343003: simple build script for webtry that re-generates the code template (Closed)

Created:
6 years, 3 months ago by humper
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

simple build script for webtry that re-generates the code template before compilation BUG=skia: Committed: https://skia.googlesource.com/skia/+/d85ad50b0ed45416f88cce4aa704ae27ca9d6ba8

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment for the build script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -159 lines) Patch
A experimental/webtry/build View 1 1 chunk +22 lines, -0 lines 0 comments Download
D experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
humper
ptal;
6 years, 3 months ago (2014-09-09 19:04:40 UTC) #2
jcgregorio
On 2014/09/09 19:04:40, humper wrote: > ptal; LGTM modulo the addition of comments.
6 years, 3 months ago (2014-09-09 19:14:05 UTC) #3
jcgregorio
https://codereview.chromium.org/552343003/diff/1/experimental/webtry/build File experimental/webtry/build (right): https://codereview.chromium.org/552343003/diff/1/experimental/webtry/build#newcode1 experimental/webtry/build:1: #!/bin/sh Needs a top level comment explaining what the ...
6 years, 3 months ago (2014-09-09 19:14:11 UTC) #4
humper
https://codereview.chromium.org/552343003/diff/1/experimental/webtry/build File experimental/webtry/build (right): https://codereview.chromium.org/552343003/diff/1/experimental/webtry/build#newcode1 experimental/webtry/build:1: #!/bin/sh On 2014/09/09 19:14:11, jcgregorio wrote: > Needs a ...
6 years, 3 months ago (2014-09-09 19:25:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/552343003/20001
6 years, 3 months ago (2014-09-09 22:49:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 22:57:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as d85ad50b0ed45416f88cce4aa704ae27ca9d6ba8

Powered by Google App Engine
This is Rietveld 408576698