Issue 552333002: Don't inline Array functions if receiver map is not extensible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552333002: Don't inline Array functions if receiver map is not extensible. (Closed)

Created:
6 years, 3 months ago by ulan

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Don't inline Array functions if receiver map is not extensible. BUG=405517 LOG=N TEST=mjsunit/regress/regress-crbug-405517.js R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23828

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-412319.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

LGTM Toon suspected that the other array functions were also vulnerable to crashing, but we ...

6 years, 3 months ago (2014-09-10 04:16:19 UTC) #3

ulan

6 years, 3 months ago (2014-09-10 09:22:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23828 (presubmit successful).