[Telemetry]: Add PeaceKeeper Benchmark suite(Render, DOM, String and Array tests).

[Telemetry]: Add PeaceKeeper Benchmark suite(Render, DOM, String and Array tests).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233474

[prasadv, 2013-11-04 21:10:48]

Hi Tony,
  I'm adding Peacekeeper benchmark suite to telemetry. This CL includes
Rendering, DOM, String and Array test suites. I'll add remaining test if this
approach looks good to you.
I'd split entire Peacekeeper benchmark into individual test suite and created
.wpr using "debug=true" query param. As per my understanding this param is only
used to display console message and doesn't have any impact on test score.
Please let me know if you need any further information.

[tonyg, 2013-11-06 21:51:55]

lgtm

Beautiful! Thank you :)

Please feel free to land when the nits below are addressed.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
File tools/perf/benchmarks/peacekeeper.py (right):

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:60: util.WaitFor(_IsDone, 600)
We have a new primitive now, tab.WaitForJavaScriptExpression(). Please use that
instead.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:92:
"repeat=false&forceSuiteName=%s&forceTestName=%s") %
Nice find! I'm glad you figured out a way to split these up and automate them :)

Annie and I both looking into this and never figured it out.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:162: test_param = ['domGetElements',
'domDynamicCreationCreateElement',
Recommend one string per line just for readability/maintainability.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/test-info.json
File tools/perf/test-info.json (right):

https://codereview.chromium.org/55233007/diff/40001/tools/perf/test-info.json...
tools/perf/test-info.json:156: "description":"Peacekeeper measures browser's
performance by testing its JavaScript functionality.\n\nJavaScript is a widely
used programming language used in the creation of modern websites to provide
features such as animation, navigation,forms and other common requirements. By
measuring a browser's ability to handle commonly used JavaScript functions
Peacekeeper can evaluate its performance. Peacekeeper scores are measured in
operations per second or rendered frames per second depending on the test. Final
Score is computed by calculating geometric mean of individual tests scores.
(http://peacekeeper.futuremark.com)",
Use markdown format for the link. See robohornet_pro's link above.

[prasadv, 2013-11-06 22:54:45]

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
File tools/perf/benchmarks/peacekeeper.py (right):

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:60: util.WaitFor(_IsDone, 600)
On 2013/11/06 21:51:55, tonyg wrote:
> We have a new primitive now, tab.WaitForJavaScriptExpression(). Please use
that
> instead.

Done.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:92:
"repeat=false&forceSuiteName=%s&forceTestName=%s") %
On 2013/11/06 21:51:55, tonyg wrote:
> Nice find! I'm glad you figured out a way to split these up and automate them
:)
> 
> Annie and I both looking into this and never figured it out.

Done.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/benchmarks/pea...
tools/perf/benchmarks/peacekeeper.py:162: test_param = ['domGetElements',
'domDynamicCreationCreateElement',
On 2013/11/06 21:51:55, tonyg wrote:
> Recommend one string per line just for readability/maintainability.

Done.

https://codereview.chromium.org/55233007/diff/40001/tools/perf/test-info.json
File tools/perf/test-info.json (right):

https://codereview.chromium.org/55233007/diff/40001/tools/perf/test-info.json...
tools/perf/test-info.json:156: "description":"Peacekeeper measures browser's
performance by testing its JavaScript functionality.\n\nJavaScript is a widely
used programming language used in the creation of modern websites to provide
features such as animation, navigation,forms and other common requirements. By
measuring a browser's ability to handle commonly used JavaScript functions
Peacekeeper can evaluate its performance. Peacekeeper scores are measured in
operations per second or rendered frames per second depending on the test. Final
Score is computed by calculating geometric mean of individual tests scores.
(http://peacekeeper.futuremark.com)",
On 2013/11/06 21:51:55, tonyg wrote:
> Use markdown format for the link. See robohornet_pro's link above.

Done.

[commit-bot: I haz the power, 2013-11-06 23:09:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prasadv@chromium.org/55233007/100001

[commit-bot: I haz the power, 2013-11-07 01:54:20]

Change committed as 233474